Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill grandchildren spun up by child processes #258

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Kill grandchildren spun up by child processes #258

merged 2 commits into from
Jul 26, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jul 26, 2018 •
edited
Loading

Fixes #247.

@balopat balopat changed the title Kill grandchildren of child processes Kill grandchildren spun up by child processes Jul 26, 2018
priyawadhwa
priyawadhwa approved these changes Jul 26, 2018
View reviewed changes
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@balopat balopat merged commit ba4c7f4 into GoogleContainerTools:master Jul 26, 2018
@balopat balopat deleted the fix_247_daemons branch July 26, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balopat @priyawadhwa