remove single kubeContext validation (#6394)

GoogleContainerTools · Aug 11, 2021 · 2664f56 · 2664f56
1 parent a453306
commit 2664f56
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 89 deletions.
diff --git a/pkg/skaffold/schema/validation/validation.go b/pkg/skaffold/schema/validation/validation.go
@@ -80,7 +80,6 @@ func Process(configs parser.SkaffoldConfigSet, validateConfig Options) error {
 		errs = append(errs, wrapWithContext(config, cfgErrs...)...)
 	}
 	errs = append(errs, validateArtifactDependencies(configs)...)
-	errs = append(errs, validateSingleKubeContext(configs)...)
 	if validateConfig.CheckDeploySource {
 		// TODO(6050) validate for other deploy types - helm, kpt, etc.
 		errs = append(errs, validateKubectlManifests(configs)...)
@@ -554,19 +553,6 @@ func validateLogPrefix(lc latestV1.LogsConfig) []error {
 	return nil
 }
 
-func validateSingleKubeContext(configs parser.SkaffoldConfigSet) []error {
-	if len(configs) < 2 {
-		return nil
-	}
-	k := configs[0].Deploy.KubeContext
-	for _, c := range configs {
-		if c.Deploy.KubeContext != k {
-			return []error{errors.New("all configs should have the same value for `deploy.kubeContext`")}
-		}
-	}
-	return nil
-}
-
 // validateCustomTest
 // - makes sure that command is not empty
 // - makes sure that dependencies.ignore is only used in conjunction with dependencies.paths

diff --git a/pkg/skaffold/schema/validation/validation_test.go b/pkg/skaffold/schema/validation/validation_test.go
@@ -18,7 +18,6 @@ package validation
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -1248,80 +1247,6 @@ func TestValidateUniqueDependencyAliases(t *testing.T) {
 	testutil.CheckDeepEqual(t, expected, errs, cmp.Comparer(errorsComparer))
 }
 
-func TestValidateSingleKubeContext(t *testing.T) {
-	tests := []struct {
-		description string
-		configs     []*latestV1.SkaffoldConfig
-		err         []error
-	}{
-		{
-			description: "different kubeContext specified",
-			configs: []*latestV1.SkaffoldConfig{
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{
-							KubeContext: "",
-						},
-					},
-				},
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{
-							KubeContext: "foo",
-						},
-					},
-				},
-			},
-			err: []error{errors.New("all configs should have the same value for `deploy.kubeContext`")},
-		},
-		{
-			description: "same kubeContext specified",
-			configs: []*latestV1.SkaffoldConfig{
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{
-							KubeContext: "foo",
-						},
-					},
-				},
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{
-							KubeContext: "foo",
-						},
-					},
-				},
-			},
-		},
-		{
-			description: "no kubeContext specified",
-			configs: []*latestV1.SkaffoldConfig{
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{},
-					},
-				},
-				{
-					Pipeline: latestV1.Pipeline{
-						Deploy: latestV1.DeployConfig{},
-					},
-				},
-			},
-		},
-	}
-
-	for _, test := range tests {
-		testutil.Run(t, test.description, func(t *testutil.T) {
-			set := parser.SkaffoldConfigSet{}
-			for _, c := range test.configs {
-				set = append(set, &parser.SkaffoldConfigEntry{SkaffoldConfig: c})
-			}
-			errs := validateSingleKubeContext(set)
-			t.CheckDeepEqual(test.err, errs, cmp.Comparer(errorsComparer))
-		})
-	}
-}
-
 func TestValidateValidDependencyAliases(t *testing.T) {
 	cfgs := parser.SkaffoldConfigSet{
 		&parser.SkaffoldConfigEntry{