Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete #5176

Closed
ghost opened this issue Dec 21, 2020 · 9 comments
Closed

delete #5176

ghost opened this issue Dec 21, 2020 · 9 comments
Labels
area/push kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/p2 May take a couple of releases

Comments

@ghost
Copy link

ghost commented Dec 21, 2020

I've finally learned what "upward compatible" means.  It means we get to
keep all our old mistakes.
		-- Dennie van Tassel
@othercorey
Copy link

I had to revert to 1.16.0 to get my images to push to remote repository at all.

@briandealwis
Copy link
Member

Hi @othercorey. Do you have any settings for local-cluster in your ~/.skafold/config file? Could you include the output of running with -v debug?

There were some changes to this with #5012, but when I run with docker-desktop, I see push-images being set to false:

...
INFO[0000] applying profile: docker-desktop             
...
INFO[0000] Using kubectl context: docker-desktop        
DEBU[0000] Using builder: local                         
...
DEBU[0000] push value not present, defaulting to false because cluster.PushImages is false 

@briandealwis briandealwis added the needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug label Dec 21, 2020
@nkubala nkubala added area/push kind/bug Something isn't working priority/p1 High impact feature/bug. labels Jan 8, 2021
@gsquared94
Copy link
Collaborator

@braderhart I'm wondering if the profile isn't being applied correctly. Can you try embedding this build stanza directly in the main pipeline instead of using a profile and see if you still encounter this issue?

apiVersion: skaffold/v2beta10
kind: Config

build:
  local:
    useBuildkit: true
  artifacts:
  - context: docker/aria2
    docker:
      buildArgs:
        ARIA2_VERSION: 1.35.0
      noCache: true
    image: equalos/aria2
  tagPolicy:
    envTemplate:
      template: alpine

metadata:
  name: aria2

@briandealwis
Copy link
Member

And can you include your ~/.skaffold/config too please?

@briandealwis
Copy link
Member

briandealwis commented Mar 6, 2021

@braderhart do you have any other contexts defined? (specifically non-local clusters)

@tejal29
Copy link
Member

tejal29 commented Apr 6, 2021

hmm looks like when you specify the kube-context, we grab the local-cluster bool and detect its a local cluster.

kubeContexts:
- kube-context: docker-desktop
  local-cluster: true

May be there is a bug on how we apply profiles.

@MarlonGamez MarlonGamez added priority/p2 May take a couple of releases and removed priority/p1 High impact feature/bug. labels Apr 26, 2021
@aaron-prindle
Copy link
Contributor

@tejaldesai were you able to reproduce this issue? I wasn't sure from your above comment, currently this has needs-reproduction

@gsquared94
Copy link
Collaborator

seems like a dupe of #5334

@nkubala
Copy link
Contributor

nkubala commented Aug 4, 2021

@braderhart can you confirm this is still an issue on the latest version of skaffold (or any version later than v1.27.0)? it seems that this has been fixed in #6024 but I want to be sure before closing this issue.

@ghost ghost closed this as completed Aug 7, 2021
@ghost ghost changed the title Build pushing images for local cluster in 1.17.2 delete May 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/push kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

7 participants