-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kind-disable-load and k3d-disable-load config values #5012
feat: add kind-disable-load and k3d-disable-load config values #5012
Conversation
20dd35e
to
905e6bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #5012 +/- ##
==========================================
+ Coverage 72.28% 72.40% +0.12%
==========================================
Files 368 368
Lines 12927 12934 +7
==========================================
+ Hits 9344 9365 +21
+ Misses 2891 2883 -8
+ Partials 692 686 -6
Continue to review full report at Codecov.
|
Push is enabled automatically if load is disabled for either kind/k3d. |
Build failure for one of the jobs seems intermittent as it shows maven download error. |
e6f7362
to
1f7888f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! PR looks great, but I think we shouldn't make isDefaultLocal
function more ambiguous by checking for IsImageLoadingRequired
inside it since it might be used in some other context later.
1f7888f
to
0c2bc50
Compare
Build seems to be failing on gci lint check in unchanged file. |
3edacc6
to
c2ecacd
Compare
55c36a1
to
af66392
Compare
BTW this could be extended in future PR to support: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry. Edit: build seems to be failing on flaky java tests downloading maven packages again. |
af66392
to
4a7c351
Compare
…mageLoadingRequired
…about local, push and load settings
4a7c351
to
b9bfaed
Compare
@gsquared94 care to review? Review comments were addressed 9 days ago. |
Sorry for the delay. I was out on vacation. Will take a look first thing in the morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
any plan to backport this feature to 0.16.x for people still stuck to Helm 2? |
@zanitete unfortunately not :( Helm 2 has been EOL'd so we're not putting work into supporting it. sorry about that |
Fixes: #3461
Description
Add two new configuration options
kind-disable-load
andk3d-disable-load
to allow disabling image loading for local kind and k3d clusters.This significantly improves deployment times to Kind.
Configuration
Demo
make bootstrap
skaffold run --force
(job is being deployed, therefore force flag is required)