Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service labeling temporarily #959

Closed
balopat opened this issue Sep 7, 2018 · 0 comments
Closed

Remove service labeling temporarily #959

balopat opened this issue Sep 7, 2018 · 0 comments
Assignees
@dgageot
Labels
area/labels kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@balopat
Copy link
Contributor

balopat commented Sep 7, 2018

We should remove adding skaffold labels to services temporarily as a stop gap measure to fix #887 until kubernetes/kubernetes#68087 is picked into GKE releases.
@balopat balopat added priority/p0 Highest priority. We are actively looking at delivering it. kind/bug Something isn't working area/labels labels Sep 7, 2018
@dgageot dgageot self-assigned this Sep 11, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 11, 2018
@dgageot
Remove service labeling temporarily
91ef1f6 
Fixes GoogleContainerTools#959

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Sep 11, 2018
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 12, 2018
@dgageot
Remove service labeling temporarily
bd39ddc 
Fixes GoogleContainerTools#959

Signed-off-by: David Gageot <david@gageot.net>
@tejal29 tejal29 mentioned this issue May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/labels kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @balopat