Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not tail logs in dev mode #1037

Closed

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 26, 2018

No description provided.

@dgageot
Copy link
Contributor Author

dgageot commented Sep 26, 2018

@MrTrustor Can you TAL and see if this solves your issue?

@codecov-io
Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #1037 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   39.98%   39.95%   -0.03%     
==========================================
  Files          70       70              
  Lines        3079     3081       +2     
==========================================
  Hits         1231     1231              
- Misses       1721     1723       +2     
  Partials      127      127
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 54.59% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbf5ac...b4dd1fb. Read the comment docs.

@MrTrustor
Copy link
Contributor

It does solve my issue, but the "true" default value is not taken into account. I have to do skaffold dev --tail=true to see the logs.

@dgageot
Copy link
Contributor Author

dgageot commented Sep 26, 2018

I’ll how to fix that tomorrow

@dgageot
Copy link
Contributor Author

dgageot commented Sep 27, 2018

Ok, so different default values for the same flag is not possible with cobra. See spf13/viper#233

@MrTrustor
Copy link
Contributor

@dgageot My (ugly) patch in #1029 did work. What do you want to do?

@dgageot dgageot added the wip label Sep 27, 2018
@dgageot
Copy link
Contributor Author

dgageot commented Sep 28, 2018

@MrTrustor I'm LGTMing your PR (#1029). Closing this one!

@dgageot dgageot closed this Sep 28, 2018
@dgageot dgageot deleted the MrTrustor-no-logs-dev branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants