Add zsh completion #1531
Merged
Add zsh completion #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
==========================================
- Coverage 45.18% 45.15% -0.03%
==========================================
Files 115 115
Lines 4794 4797 +3
==========================================
Hits 2166 2166
- Misses 2403 2406 +3
Partials 225 225
Continue to review full report at Codecov.
|
dgageot
suggested changes
Jan 25, 2019
| // Only bash is supported for now. However, having args after | ||
| // "completion" will help when supporting multiple shells | ||
| Use: "completion bash", | ||
| Use: "completion SHELL", | ||
| Args: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) != 1 { |
There was a problem hiding this comment.
Could it default to bash to not break existing usage?
There was a problem hiding this comment.
Well, skaffold completion by itself was never valid but would print the help text. Only skaffold completion bash was allowed and that didn't change.
I also checked kubectl and minikube and neither defaults to bash. So I think the current behavior is most consistent and should not be changed.
dgageot
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds command completion for skaffold in zsh. It uses the cobra zsh completion generator. Cobra has only limited support for completion in zsh, for example options are not included in the completion unlike for bash completion. However, a revised completion generator is in the works (spf13/cobra#646), so that it didn't seem reasonable to build a custom temporary solution. Therefore, this zsh completion for skaffold is still a bit basic, but hopefully will improve soon.
For the long command description, I aligned the help text with minikube.
Fixes #1012