add serviceAccount and runAsUser to kaniko build (resolves #3267) #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSel
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
|
Thanks @DanielSel for your PR. Thank you so much! Looking forward to get this in! |
DanielSel
force-pushed
the
feature/security-context
branch
from
43a5fad
to
57a1c32
Compare
Codecov Report
|
Merged
DanielSel
force-pushed
the
feature/security-context
branch
from
57a1c32
to
46f7c5c
Compare
DanielSel
force-pushed
the
feature/security-context
branch
from
46f7c5c
to
d7ec698
Compare
tejal29
approved these changes
Apr 29, 2020
|
LGTM! will get this in today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3267
Description
Add configuration options for serviceAccount and runAsUser.
This allows building in clusters with PodSecurityPolicies (bound to serviceAccount) and OKD/OpenShift 3.11 (requires runAsUser to be set to avoid auto-apply of 'restricted' scc)