Add ImageOptions to artifact builder.
#4467
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,82 @@ | ||||||
| /* | ||||||
| Copyright 2019 The Skaffold Authors | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| you may not use this file except in compliance with the License. | ||||||
| You may obtain a copy of the License at | ||||||
|
|
||||||
| http://www.apache.org/licenses/LICENSE-2.0 | ||||||
|
|
||||||
| Unless required by applicable law or agreed to in writing, software | ||||||
| distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| See the License for the specific language governing permissions and | ||||||
| limitations under the License. | ||||||
| */ | ||||||
|
|
||||||
| package buildpacks | ||||||
|
|
||||||
| import "github.com/buildpacks/pack" | ||||||
|
|
||||||
| var buildArgsForDebug = map[string]string{ | ||||||
| "GOOGLE_GOGCFLAGS": "'all=-N -l'", // disable build optimization for Golang | ||||||
| // TODO: Add for other languages | ||||||
| } | ||||||
|
|
||||||
| var buildArgsForDev = map[string]string{ | ||||||
| "GOOGLE_GOLDFLAGS": "-w", // omit debug information in build output for Golang | ||||||
| // TODO: Add for other languages | ||||||
| } | ||||||
|
|
||||||
| type BuildOptionsModifier func(*pack.BuildOptions) *pack.BuildOptions | ||||||
|
|
||||||
| type BuildOptions struct { | ||||||
| Tag string | ||||||
| modifiers []BuildOptionsModifier | ||||||
| } | ||||||
|
|
||||||
| func (b *BuildOptions) AddModifier(m BuildOptionsModifier) *BuildOptions { | ||||||
| b.modifiers = append(b.modifiers, m) | ||||||
| return b | ||||||
| } | ||||||
|
|
||||||
| func (b *BuildOptions) ApplyModifiers(opts *pack.BuildOptions) *pack.BuildOptions { | ||||||
| for _, modifier := range b.modifiers { | ||||||
| opts = modifier(opts) | ||||||
| } | ||||||
| return opts | ||||||
| } | ||||||
|
|
||||||
| func OptimizeBuildForDebug(opts *pack.BuildOptions) *pack.BuildOptions { | ||||||
| if opts == nil { | ||||||
| opts = &pack.BuildOptions{} | ||||||
| } | ||||||
|
|
||||||
| if opts.Env == nil { | ||||||
| opts.Env = make(map[string]string) | ||||||
| } | ||||||
|
|
||||||
| for k, v := range buildArgsForDebug { | ||||||
| if _, exists := opts.Env[k]; !exists { | ||||||
| opts.Env[k] = v | ||||||
| } | ||||||
| } | ||||||
| return opts | ||||||
| } | ||||||
|
|
||||||
| func OptimizeBuildForDev(opts *pack.BuildOptions) *pack.BuildOptions { | ||||||
| if opts == nil { | ||||||
| opts = &pack.BuildOptions{} | ||||||
| } | ||||||
|
|
||||||
| if opts.Env == nil { | ||||||
| opts.Env = make(map[string]string) | ||||||
| } | ||||||
|
|
||||||
| for k, v := range buildArgsForDev { | ||||||
| if _, exists := opts.Env[k]; !exists { | ||||||
| opts.Env[k] = v | ||||||
| } | ||||||
| } | ||||||
| return opts | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't die on this hill, but this is really supposed to be the most minimal possible example, so this is kind of straying from that. maybe these can go in another example for debug? I don't care too much though