Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return of error adding artifacts to cache when images are built remotely #4850

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Fix return of error adding artifacts to cache when images are built remotely #4850

merged 3 commits into from
Oct 2, 2020

Conversation

ricardo-larosa
Copy link
Contributor

Fixes: #4848

Description
Fix return error adding artifacts to cache when builds are not local

@ricardo-larosa ricardo-larosa requested a review from a team as a code owner October 2, 2020 10:52
@ricardo-larosa ricardo-larosa changed the title Fix return of error when images are built remotely Fix return of error adding artifacts to cache when images are built remotely Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #4850 into master will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4850   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files         356      356           
  Lines       12215    12216    +1     
=======================================
+ Hits         8777     8778    +1     
  Misses       2786     2786           
  Partials      652      652
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 68.60% <71.42%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68eab61...834d6a8. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Oct 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Oct 2, 2020
tejal29
tejal29 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @ricardo-larosa
The change looks good to me

@gsquared94 gsquared94 merged commit 3c10069 into GoogleContainerTools:master Oct 2, 2020
@briandealwis briandealwis mentioned this pull request Oct 5, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsquared94 gsquared94 gsquared94 left review comments

@tejal29 tejal29 tejal29 approved these changes

@MarlonGamez MarlonGamez Awaiting requested review from MarlonGamez

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaffold will always return error adding artifacts to cache when builds are not local
5 participants
@ricardo-larosa @tejal29 @gsquared94 @googlebot @kokoro-team