Don't single-quote SKAFFOLD_GO_GCFLAGS #4864
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4863
Related to: #4606
Description
We can't wrap the
SKAFFOLD_GO_GCFLAGS
value in single-quotes. Although the compiler doesn't complain, it doesn't apply the flags and so we end up with:Verified with Docker and Buildpacks builder.
User facing changes (remove if N/A)
SKAFFOLD_GO_GCFLAGS
is now properly quoted