Support minikube 1.13.0 and later with --vm-driver=none
#4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4887 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 356 356
Lines 12220 12220
=======================================
Hits 8782 8782
Misses 2786 2786
Partials 652 652
Continue to review full report at Codecov.
|
gsquared94
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4868
Description
Minikube 1.13.0 changed its exit codes, such that
minikube docker-envfor a profie withvm-driver=nonenow exits with 51 (ExDriverConflict), and not 64 (BadUsage) like before. Exit code 51 was unused prior to minikube 1.13.0, so we can just check minikube's exit code for both values.