-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an init phase to detect skaffold errors even before skaffold runner is created. #4926
Conversation
…d in the initial phase. If, Minikube is not running, and skaffold deploy context is set to "minikube", skaffold fails when creating a runner. This failure has no phase attached to it. Adding a Init Phase, will help reduce errors where "UNKNOWN_ERROR" is seen to "INIT_KNOWNN"
Codecov Report
@@ Coverage Diff @@
## master #4926 +/- ##
==========================================
+ Coverage 72.18% 72.36% +0.17%
==========================================
Files 358 360 +2
Lines 12402 12474 +72
==========================================
+ Hits 8953 9027 +74
+ Misses 2795 2789 -6
- Partials 654 658 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than logEntry
arriving out of order seems like a pre-existing issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggested renames, mostly to avoid confusion with skaffold init
, and minor nits.
f19f3a9
to
39e554e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit
Relates to #4692
Add distinct error codes to reduce "UNKNOWN_ERROR" when skaffold was not able to create a runner.
where phase= "UNKNOWN", and error code is "ERROR"
This happens when
skaffold.NewForConfig
fails when skaffold fails to createAny errors occurred here will now be part of "INIT" phase.
This PR also identifies failure when deploy context is minikube and minikube cluster is stopped.
On master run
minikube stop
kubectl config use-context minikube
skaffold dev
Error,
With this PR
Make sure the error is seen in Event API
Since this happens pretty fast, In another terminal run
in test.txt