Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent conflicts with AMP plugin #3

Closed
swissspidy opened this issue Jan 22, 2020 · 4 comments
Closed

Prevent conflicts with AMP plugin #3

swissspidy opened this issue Jan 22, 2020 · 4 comments
Assignees
Labels
Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Jan 22, 2020

This includes things like changing the post type name, etc.

Slightly related: #2.


QA testing instructions

  1. Verify that creating, saving, and viewing stories works with the AMP plugin inactive
  2. Verify that creating, saving, and viewing stories works with the AMP plugin active, but the stories experience disabled
  3. When activating the stories experience, both "Stories" options should be visible in the admin menu
  4. Verify that creating, saving, and viewing stories works with the AMP plugin active, and the stories experience enabled
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Jan 22, 2020
@swissspidy swissspidy self-assigned this Jan 23, 2020
@kmyram kmyram added this to the Sprint 22 milestone Jan 23, 2020
@kmyram
Copy link

kmyram commented Feb 5, 2020

@swissspidy Seems to be missing QA-instructions?

@swissspidy
Copy link
Collaborator Author

Added some instructions, sorry for the delay.

Please not that this somewhat of a moving target as there is work being done on the AMP plugin at the same time that affects this. See ampproject/amp-wp#4219 and ampproject/amp-wp#4217 for example.

@csossi
Copy link

csossi commented Feb 28, 2020

Hi @swissspidy - posted a simple story (1 page, background image only), and Chrome's AMP Validator kicked out the following error:
image

@swissspidy
Copy link
Collaborator Author

The canonical tag will only be added once the story is published—not when it's still a draft.

#346 is adding it for drafts too though, so should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants