-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery: Ensure compatibility with new Web Stories plugin #4172
Comments
Is there an issue when the Stories experience is turned off in the AMP plugin? One suggestion is activating the Web Stories plugins should force the Stories experience to be disabled in the AMP plugin. Once the Web Stories plugin is available on WordPress.org, we should remove the experiences options and add a CTA to try out Web Stories. |
We had a discussion with Paul and Sam yesterday on the best way to proceed
regarding the removal of the editor from the AMP plugin. We'll discuss it
today and update this thread.
Em sex., 24 de jan. de 2020 às 11:14, Weston Ruter <notifications@github.com>
escreveu:
… Is there an issue when the Stories experience is turned off in the AMP
plugin?
One suggestion is activating the Web Stories plugins should force the
Stories experience to be disabled in the AMP plugin.
Once the Web Stories plugin is available on WordPress.org, we should
remove the experiences options and add a CTA to try out Web Stories.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4172?email_source=notifications&email_token=AAD3R2OSOZAOGLIEHIQA3GDQ7M4YDA5CNFSM4KLHIA7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3ZKJQ#issuecomment-578262310>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD3R2MM6DNCGIGRYCNCXCDQ7M4YDANCNFSM4KLHIA7A>
.
|
As noted in #4074 (comment): We need to disable the AMP Stories experience if either the user is on WordPress version under 5.3 or they have a Gutenberg version that is too new. Additionally, we need to hide the Stories experience entirely (the experience checkboxes) if the user has no |
See #4200.
See #4201. |
And #4202 for adding a notice to the impending minor release to alert users that the Stories experience bundled with the AMP plugin is deprecated and they need to export them, and then to look out for the Web Stories plugin. |
And see #4203 which removes the AMP Stories experience from the AMP plugin. |
I believe this discovery has been completed. |
Feature description
With the new repo for the stories editor soon taking off, we need to ensure the two plugins work flawlessly together.
While the Web Stories plugin already works well standalone, there still seems to be some interference. For example with hooks/filters and rewrites.
The same issue is also being tracked from the other repo's perspective: GoogleForCreators/web-stories-wp#3
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: