Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: Ensure compatibility with new Web Stories plugin #4172

Closed
swissspidy opened this issue Jan 24, 2020 · 7 comments
Closed

Discovery: Ensure compatibility with new Web Stories plugin #4172

swissspidy opened this issue Jan 24, 2020 · 7 comments

Comments

@swissspidy
Copy link
Collaborator

Feature description

With the new repo for the stories editor soon taking off, we need to ensure the two plugins work flawlessly together.

While the Web Stories plugin already works well standalone, there still seems to be some interference. For example with hooks/filters and rewrites.

The same issue is also being tracked from the other repo's perspective: GoogleForCreators/web-stories-wp#3


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@swissspidy swissspidy added the Stories Stories Editor label Jan 24, 2020
@westonruter
Copy link
Member

Is there an issue when the Stories experience is turned off in the AMP plugin?

One suggestion is activating the Web Stories plugins should force the Stories experience to be disabled in the AMP plugin.

Once the Web Stories plugin is available on WordPress.org, we should remove the experiences options and add a CTA to try out Web Stories.

@amedina
Copy link
Member

amedina commented Jan 24, 2020 via email

@westonruter
Copy link
Member

As noted in #4074 (comment):

We need to disable the AMP Stories experience if either the user is on WordPress version under 5.3 or they have a Gutenberg version that is too new.

Additionally, we need to hide the Stories experience entirely (the experience checkboxes) if the user has no amp_story posts created. The thinking being that we can continue to allow access to Stories for users who are using them, but we discontinue offering the Stories feature for new installs or people who don't have stories created. In the place of the experience checkboxes, there can be a notice that says a new Stories plugin is coming and link to it when it is available for testing.

@westonruter
Copy link
Member

We need to disable the AMP Stories experience if either the user is on WordPress version under 5.3 or they have a Gutenberg version that is too new.

See #4200.

Additionally, we need to hide the Stories experience entirely (the experience checkboxes) if the user has no amp_story posts created. The thinking being that we can continue to allow access to Stories for users who are using them, but we discontinue offering the Stories feature for new installs or people who don't have stories created. In the place of the experience checkboxes, there can be a notice that says a new Stories plugin is coming and link to it when it is available for testing.

See #4201.

@westonruter
Copy link
Member

And #4202 for adding a notice to the impending minor release to alert users that the Stories experience bundled with the AMP plugin is deprecated and they need to export them, and then to look out for the Web Stories plugin.

@westonruter
Copy link
Member

And see #4203 which removes the AMP Stories experience from the AMP plugin.

@westonruter westonruter added this to the v1.5 milestone Jan 30, 2020
@swissspidy swissspidy added Integration: Web Stories and removed Stories Stories Editor labels Feb 18, 2020
@kmyram kmyram changed the title Ensure compatibility with new Web Stories plugin Discovery: Ensure compatibility with new Web Stories plugin Feb 18, 2020
@kmyram kmyram added the Size: S label Feb 18, 2020
@westonruter westonruter removed this from the v1.5 milestone Mar 12, 2020
@amedina amedina removed the Size: S label Mar 31, 2020
@westonruter
Copy link
Member

I believe this discovery has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants