Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes masking on mobile #727

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fixes masking on mobile #727

merged 1 commit into from
Mar 24, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Mar 24, 2020

Closes #689

@wassgha
Copy link
Contributor Author

wassgha commented Mar 24, 2020

@swissspidy looks like stylelint should be able to allow this but it doesn't...

@github-actions
Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 433 kB

Filename Size Change
assets/js/edit-story.js 369 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 241 B 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 63.4 kB 0 B

compressed-size-action

@wassgha wassgha merged commit ada85c3 into master Mar 24, 2020
@wassgha wassgha deleted the fix/clip-path-ios branch March 24, 2020 05:17
@swissspidy
Copy link
Collaborator

looks like stylelint should be able to allow this but it doesn't...

@wassgha It kinda makes sense though: We use styled components everywhere, which deals with prefixes automatically. No need to do prefixes manually, hence the property-no-vendor-prefix rule. Also, the rule only complains about prefixes it knows tools like Autoprefixer and styled components can handle. However, Stylelint doesn't know we cannot use these tools in this file.

obetomuniz added a commit that referenced this pull request Mar 24, 2020
* master: (89 commits)
  Bump webpack from 4.42.0 to 4.42.1 (#740)
  Lint fixes
  Move DEFAULT_LINK declaration to within LinkPanel
  Bump lint-staged from 10.0.8 to 10.0.9 (#728)
  Fix clip path on iOS Chrome (#727)
  Bump @wordpress/components from 9.2.4 to 9.2.5 (#722)
  Performance & aesthetic improvements for drop targets (#687)
  Fix LinkType default arg hack due to module loading errors
  Temp fix for LinkType problem
  lints
  Bump prettier from 2.0.1 to 2.0.2 (#721)
  Lots and lots and lots of tests
  fixed tests
  transparent color formatting
  Color migrated
  Migrated most of the panels, except for color
  Save on selection change
  News tests for DesignPanel and related features
  Auto-submit for all forms
  Text style support
  ...
obetomuniz added a commit that referenced this pull request Mar 24, 2020
* master: (81 commits)
  Bump webpack from 4.42.0 to 4.42.1 (#740)
  Lint fixes
  Move DEFAULT_LINK declaration to within LinkPanel
  Bump lint-staged from 10.0.8 to 10.0.9 (#728)
  Fix clip path on iOS Chrome (#727)
  Bump @wordpress/components from 9.2.4 to 9.2.5 (#722)
  Performance & aesthetic improvements for drop targets (#687)
  Fix LinkType default arg hack due to module loading errors
  Temp fix for LinkType problem
  lints
  Bump prettier from 2.0.1 to 2.0.2 (#721)
  Lots and lots and lots of tests
  fixed tests
  transparent color formatting
  Color migrated
  Migrated most of the panels, except for color
  Save on selection change
  News tests for DesignPanel and related features
  Auto-submit for all forms
  Text style support
  ...
@swissspidy swissspidy added the Type: Bug Something isn't working label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masking Not Rendered on Mobile
4 participants