Fix : DIG-177 FCM 웹 푸시 버그 수정 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YEJINGO
force-pushed
the
feature/alarm2
branch
2 times, most recently
from
edd888e
to
882f637
Compare
dunowljj
requested changes
Nov 26, 2023
src/main/java/com/ogjg/daitgym/alarm/service/ScheduledService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ogjg/daitgym/alarm/service/FcmTokenService.java
Outdated
Show resolved
Hide resolved
- 알림을 차단하고, 허용했을 때 새로운 FCM토큰이 발급되는데 이때, 전 토큰값이 그대로 DB에 저장되어 FCM 웹푸시가 되지 않음
- 새로운 토큰이 들어왔을 때, 전 토큰값을 삭제하고 새로운 토큰을 저장
리팩토링
- FcmToken, FCMAlarm 서비스 분리
- 토큰 생성/수정/삭제 로직과 웹푸시 알람 보내는 메서드 분리
- FcmToken Entity 연관관계 수정
- @OnetoOne -> @manytoone로 수정하여 User를 FK로 설정
- 고유의 id값을 PK로 설정
- ScheduledService 내용 수정
- 운동일지가 비었을 때, 비어있다는 알림 추가
- NotificationApiController 삭제, FcmTokenController 로 변경
YEJINGO
force-pushed
the
feature/alarm2
branch
from
882f637
to
d7c8c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리팩토링