Refactor, Fix : S3Service 생성하여 유저관련 s3 로직 분리, 프로필 편집 기능 nickname 중복 버그 수정 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- s3에 image 파일 저장 로직 분리 - img -> images로 통일 - todo - 여전히 중복되는 파일, 컬렉션 null 체크 로직 존재 - CascadeType.ALL 적용
- put 메서드라 매번 전체 프로필 정보가 request에 전달돼서 문제가 생겼다. - 닉네임 중복 체크 시 자신의 닉네임인지도 확인하도록 수정
- isFollwer의 주체가 누군지 헷갈리는 것을 방지하기 위해 메서드 이름으로 의미를 나타냈다.
dunowljj
force-pushed
the
feature/profile
branch
from
6e7ce22
to
305e383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor : DIG-135 S3Service 생성하여 유저관련 s3 로직 분리
Fix : DIG-111 회원 프로필 편집 기능 nickname을 바꾸지 않으면 중복 로직에 걸리는 버그 수정
Refactor : DIG-135 회원 프로필 불러오기 기능 메서드 추출