Skip to content

Commit

Permalink
Comment addressed for pull request (regarding bias issue in convtrans…
Browse files Browse the repository at this point in the history
…pose.cc)

Removed .DS_Store files
Removed a previous comment stating that bias was not tested in convtranspose.cc
Added myself to the blamelist as suggested.
Enabled the following ONNX tests:
1) ONNX_backend_pytorch_converted_test(ConvTranspose2d)
2) ONNX_backend_pytorch_converted_test(ConvTranspose2d_no_bias)
  • Loading branch information
YoungsunUConn authored and kraiskil committed Feb 4, 2024
1 parent 5b20387 commit 4f772bb
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 1 deletion.
Binary file removed .DS_Store
Binary file not shown.
1 change: 1 addition & 0 deletions LICENSE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ distributing this software causes anyone any harm.
Authors:
Kalle Raiskila
Robin van Emden
Youngsun Kong
Binary file removed src/.DS_Store
Binary file not shown.
1 change: 0 additions & 1 deletion src/nodes/convtranspose.cc
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ void ConvTranspose::print_calculation( std::ostream &dst) const
INDT_1 << "} /* m */" << std::endl;
INDT_1 << "} /* b */" << std::endl;

// NB: bias is not tested by the ONNX backend tests, but docs are pretty clear here.
// YK: bias should be added only once
if( b ) {
// Create the loops over batches and maps (output channels).
Expand Down
2 changes: 2 additions & 0 deletions test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@ ONNX_backend_node_test(convtranspose_pad)
ONNX_backend_node_test(convtranspose_3d)
ONNX_backend_node_test(convtranspose_kernel_shape)
ONNX_backend_node_test(convtranspose_pads)
ONNX_backend_pytorch_converted_test(ConvTranspose2d)
ONNX_backend_pytorch_converted_test(ConvTranspose2d_no_bias)

ONNX_backend_node_test(div)
ONNX_backend_node_test(div_bcast)
Expand Down

0 comments on commit 4f772bb

Please sign in to comment.