Bitbucket OAuth. Resolve #201. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
force-pushed
the
bitbucket-oauth2
branch
3 times, most recently
from
6d88bae
to
84ca895
Compare
| return None | ||
|
|
||
|
|
||
| def set(key, value): |
There was a problem hiding this comment.
Can you add a lockfile around this? The w+ flag gives me the race-condition heebie-jeebies.
There was a problem hiding this comment.
Yes, good catch.
|
The oauth bits look fine to me. Can you look at the lockfile question above and rebase on |
ryneeverett
force-pushed
the
bitbucket-oauth2
branch
4 times, most recently
from
1c09721
to
43a827c
Compare
|
I still gotta look at the lockfile issue. FYI, I tested out using |
|
FYI, I did add a lockfile. |
|
Oh, I'd missed it. 👍 here. Feel free to merge. 🍡 |
- Implement OAuth2. Thanks to @ibuchanan for helping me navigate bitbucket's idiosyncratic implementation. - Add a bugwarrior.data file to the ~/.task directory, per [taskwarrior's third-party guidelines](https://taskwarrior.org/docs/3rd-party.html#guidelines).
- Use lockfile for writes. - Use 'r+' rather than 'rw'. (The latter raises an exception in python 3). - Catch ValueError if data file isn't JSON. - Add `get_data_path` helper function.
ryneeverett
force-pushed
the
bitbucket-oauth2
branch
from
58f0414
to
e2dfc82
Compare
ryneeverett
added a commit
that referenced
this pull request
Mar 10, 2016
Bitbucket OAuth. Resolve #201.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitbucket's idiosyncratic implementation.
third-party guidelines.