Skip to content

fix: correct LuaTable.ToDictionary to allow arrays to be values within a dictionary #5830

fix: correct LuaTable.ToDictionary to allow arrays to be values within a dictionary

fix: correct LuaTable.ToDictionary to allow arrays to be values within a dictionary #5830

Triggered via pull request November 12, 2024 19:35
Status Success
Total duration 3m 24s
Artifacts

pull-request.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build: libs/adsp-service-net-sdk/Configuration/ConfigurationStartupFilter.spec.cs#L29
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build: libs/adsp-service-net-sdk/Configuration/ConfigurationService.Spec.cs#L98
Dereference of a possibly null reference.
build: libs/adsp-service-net-sdk/Configuration/ConfigurationService.Spec.cs#L99
Dereference of a possibly null reference.
build: libs/adsp-service-net-sdk/Configuration/ConfigurationMiddleware.Spec.cs#L118
Possible null reference argument for parameter 'httpContext' in 'Task ConfigurationMiddleware.InvokeAsync(HttpContext httpContext)'.
build: apps/script-service/Services/ScriptFunctions.Spec.cs#L83
Converting null literal or possible null value to non-nullable type.
build: apps/script-service/Services/ScriptFunctions.Spec.cs#L83
Dereference of a possibly null reference.
build: apps/script-service/Services/TestUtil.cs#L81
Dereference of a possibly null reference.
build: apps/script-service/Services/TestUtil.cs#L126
Possible null reference return.
build: apps/script-service/Util/LuaTableExtensions.cs#L41
The behavior of 'Convert.ToInt32(object)' could vary based on the current user's locale settings. Replace this call in 'LuaTable.IsArray()' with a call to 'Convert.ToInt32(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: apps/script-service/Util/LuaTableExtensions.cs#L64
The behavior of 'Convert.ChangeType(object, Type)' could vary based on the current user's locale settings. Replace this call in 'LuaTable.ToArray()' with a call to 'Convert.ChangeType(object, Type, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)