fix: Form summary page , press tab could not go Edit #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d time is before Start time
thdlam
approved these changes
Nov 12, 2024
thdlam
reviewed
Nov 12, 2024
| onClick={() => setPage(index + 1)} | ||
| data-testid={testId} | ||
| onKeyDown={(e) => { | ||
| if (!readOnly && (e.key === ' ' || e.key === 'Enter')) { |
There was a problem hiding this comment.
Just a thought, maybe we should refactor create a file with all the keys we use Enter, Tab, Space into its own const variable and export it instead of hard coding it.
I have the same issue and i just put it in the DropDownTypes.ts file
There was a problem hiding this comment.
Right, I deeply agree, that will make code neat and easy to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.