-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Python 3.6-3.7 compatible via package dependencies #1454
Make Python 3.6-3.7 compatible via package dependencies #1454
Conversation
gregelin
commented
Mar 4, 2021
- Fix Dependency Error When Downloading Pip requirements #1206 importlib-metadata==3.4.0 because these package versions have conflicting dependencies #1424 re: Python 3.6-3.7 compatibility
- Stay Python 3.8-3.9 compatible
- Update related dependency license tracking comments
- Fix GovReady#1206 GovReady#1424 re: Python 3.6-3.7 compatibility - Stay Python 3.8-3.9 compatible - Update related dependency license tracking comments
@Dav1dV Can you explain how these changes may GovReady Python libraries compatible with Python 3.6 and 3.7 while maintaining compatibility with 3.8 and 3.9? Or does working with Python 3.6 and 3.7 break 3.8 and 3.9? |
@gregelin This allows 3.6-3.7 in addition to 3.8-3.9: The primary 3.6-3.7 blocker was the The only other non-comment change is adding the |
@Dav1dV That explanation helps. Thanks. |
I tested this branch with Python 3.6.9 on macOS 10.14.4 running
|
Let's put this on hold and create in the future different installs for different versions of python. |
@gregelin Pls check your environment & retry 🤔
|
Hmmm....I wonder if I was on the right branch... |
Apparently, I tested the wrong branch. The correct branch installed GovReady correctly in 3.6, 3.7, and 3.8. I also tested to see if the adjusted packages will still work after upgrading the requirements using |