Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothly attach assessment reports to systems via the API #1509

Merged
merged 19 commits into from
Apr 22, 2021

Conversation

gregelin
Copy link
Contributor

@gregelin gregelin commented Apr 1, 2021

This PR enables the smooth, automated attachment of assessment summary reports (in a particular format) to individual GovReady-Q project systems and to specific system deployments (e.g., Dev, Prod).

PR also includes a sample System Assessment Result (SAR) middleware pipeline in tools/simple_sar_server that includes a simple SAR service generating sample SAR summaries (sar.py) and SAR ETL service to transform and submit the SAR to GovReady via authenticated API (sar_etl.py).

Assessment handling

Create a simple System Assessment Result web server
generating JSON data object listing assessment summary
results that can be added to a system's assessment.

This provides a synthentic provider of SAR results data from
which we can test the UI for consuming SAR data.
Polish SAR summary page - use details tag, other improvements.
Polish SAR list page - include deployment name.

Wrap SAR test item to start to make more realistic SAR data.

Display assessment name in Assessment model admin list.
Misc improvements to sar generator and middleware.
Include description value for SAR wrapper.
Remove hardcoded values of system id and deployment id
from SAR middleware pipeline.
Pass as many values as possible in SAR wrapper object.
Properly handle UUID to string and back again
Post assessment to system without a deployment ID
Display project id, system id on project pages.
Copy link
Contributor

@davidpofo davidpofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need greg PR party 04/08

controls/views.py Show resolved Hide resolved
Copy link
Contributor

@alexanderward alexanderward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David has a change on line 3052 to be resolved.

Copy link
Contributor

@davidpofo davidpofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pr party 4/22

@davidpofo davidpofo dismissed alexanderward’s stale review April 22, 2021 20:17

extra brace not necessary

@davidpofo davidpofo merged commit 351735c into develop Apr 22, 2021
@davidpofo davidpofo deleted the ge/wazuh-march branch April 22, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants