Closes #1547 Display impact level on project page. #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement impact level as a statement about a system of type "fisma_impact_level" with imoact level in body. This continues idea that statements are factual observations about a system. Statement must be associated with system.root_element and be consumed by root_element.
davidpofo
reviewed
Apr 20, 2021
There was a problem hiding this comment.
@gregelin Needs tests. Also it is unclear how a statement that defines Fisma level looks in oscal which would be covered by an automated unit test. I suggest adding a fixture with statement data that would include a fisma level in the body as suggested.
|
@davidpofo Tests added. Currently the tests just check that content appears; content can be set with a statement in the database and updated for different content to appear. |
Enumarate different type of statements
|
@davidpofo Also added type enumeration to Statements. This is ready for review and inclusion. |
… methods Set system fisma_impact_level root_element statement as part of question action to set baseline. Since baselines could have more names than just "Low", "Moderate", and "High", we only set fisma_impact_level if baseline is one of those three. This might need to improve in the future and make setting fisma_impact_level a separate question action from setting baselines. Created set/get methods for fisma_impact_level in System model to make sure only one statement for the system with statement_type of fisma_impact_level existed. Also fixed POAM stat counting to only count POAMs associated with current system. Existing POAM count was not filtering on current system.
all caps no brakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement impact level as a statement about a system of type "fisma_impact_level"
with imoact level in body. This continues idea that statements are
factual observations about a system. Statement must be associated
with system.root_element and be consumed by root_element.