Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append '-dev' to version number #1639

Merged
merged 7 commits into from
Jul 2, 2021
Merged

Append '-dev' to version number #1639

merged 7 commits into from
Jul 2, 2021

Conversation

gregelin
Copy link
Contributor

@gregelin gregelin commented Jun 22, 2021 •
edited
Loading

Testing adding the suffix -dev to a version number to communicate the upcoming release associated with a develop branch.

This will be more useful to end-users than the current v999 we are are using.

Making this test commit to see if the VERSION format v0.9.5-dev passes tests.

@gregelin
Copy link
Contributor Author

All tests passed. So -dev suffix works.

alexanderward
alexanderward previously requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@alexanderward alexanderward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make modifications he ci pipeline. .circleci/check_version_file.py to support new format/regex

@davidpofo davidpofo dismissed alexanderward’s stale review July 2, 2021 15:17

greg has addressed this

davidpofo
davidpofo approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@davidpofo davidpofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidpofo davidpofo merged commit a03ec87 into develop Jul 2, 2021
@davidpofo davidpofo deleted the ge/version-dev-test branch July 2, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpofo davidpofo davidpofo approved these changes

@alexanderward alexanderward alexanderward left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregelin @alexanderward @davidpofo