Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import command to imports legacy control implementation statements #1645

Merged
merged 13 commits into from
Jul 1, 2021

Conversation

gregelin
Copy link
Contributor

Create custom Django admin command to batch import control implementation statements from a spreadsheet of controls exported for a system SSP. Current importer geared to CSAM exports. Creates a blank project, system, and imports legacy implementation statements as statement type control_implementation_legacy. Also create UI for displaying statements.

* [WIP] UI to display legacy control impl smts

Create a conditional display of legacy control implementation
statements in control editor page.

Also widen width of display of editor control statements
to 1250px.

* Improve display of legacy statement

* StatementTypeEnum fixes. Closes #1643

Set all `StatementTypeEnum.<LABEL>.value` to `StatementTypeEnum.<LABEL>.name`
in order for relevant label/term to show up in Django database admin interface.

Set component library detail page Systems tab to not be inactive thereby
removing the content from the System tab showing up on the Control Implementation
Statements tab.

Update controls.tests.

Co-authored-by: Greg Elin <greg.elin@govready.com>
@gregelin
Copy link
Contributor Author

@alexanderward The control IDs from the spreadsheet being imported need to be passed through the controls.utilities.oscalize_control_id to get the correct format of the sid to store with the statement.
Incorrect: MA-06. Correct: ma-6. Can you update, pls?

alexanderward and others added 7 commits June 30, 2021 12:03
Add project and system.root_element to import_record
in order to auto delete the project and system (and root element)
when the import process for importing legacy control impl smts
also creates the project.
Copy link
Contributor

@davidpofo davidpofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@davidpofo davidpofo merged commit b02d688 into develop Jul 1, 2021
@davidpofo davidpofo deleted the parser branch July 1, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants