Fix #934 infinite redirects with SSL HTTPS & NGIX #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues. First, updates NGINX configuration files to pass $request_uri port of URL from port 80 to port 443. Failing to pass $request_uri tosses user (and non-users with invites) to home page rather than requested url. Second, and more signficantly, scheme `https` in `govready-url` parameter was also setting `SECURE_SSL_REDIRECT` at the Django app causing infinite redirects behind an NGINX reverse proxy that was terminating the SSL connection and passing to local `http://localhost:8000`. Fix was to let `SECURE_SSL_REDIRECT` remain its default `False` and add new parameter `secure_ssl_redirect` for situations when deployment called on Django to handle redirect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues. Fixes #934.
First, updates NGINX configuration files to pass $request_uri
port of URL from port 80 to port 443. Failing to pass $request_uri
tosses user (and non-users with invites) to home page rather than
requested url.
Second, and more signficantly, scheme
httpsingovready-urlparameter was also setting
SECURE_SSL_REDIRECTat the Django appcausing infinite redirects behind an NGINX reverse proxy that was
terminating the SSL connection and passing to local
http://localhost:8000.Fix was to let
SECURE_SSL_REDIRECTremain its defaultFalseandadd new parameter
secure_ssl_redirectfor situations when deploymentcalled on Django to handle redirect.