Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tooltip): remove the arrowProps prop from ReactElement #281

Closed
wants to merge 1 commit into from

Conversation

sxwei123
Copy link
Contributor

Currently we use any hover based tooltip, we will get this warning:

Warning: React does not recognize the `arrowProps` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `arrowprops` instead. If you accidentally passed it from a parent component, remove it from the DOM element. Error Component Stack

This PR will surpress the warning.

@sxwei123 sxwei123 changed the title fix(Tooltip): do not apply arrowProps to ReactElement directly fix(Tooltip): remove the arrowProps prop from ReactElement Dec 12, 2024
@clukhei
Copy link
Collaborator

clukhei commented Dec 13, 2024

thanks for flagging this out, forgot to remove all arrowProps dependency when our designs changed. I will close this and open another PR to clean up all other arrowProps instead.

@clukhei
Copy link
Collaborator

clukhei commented Dec 13, 2024

fixed released in v2.7.4 @sxwei123

@sxwei123
Copy link
Contributor Author

fixed released in v2.7.4 @sxwei123

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants