fix: browser field should point to cjs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> a top-level "browser" field should point to CJS files that, when bundled by a non-broken module bundler, work in a browser browserify/browser-resolve#101 (comment) I've changed the `browser` field to point to the `cjs` version of this module in line with the above comment because this module is currently broken when used with browserify. I've also added the [util](https://www.npmjs.com/package/util) module as a dep since it's used in the code. It would be ignored in most environments so the only cost is a slightly larger bundle but it's likely to be included in any non-trivial bundle somewhere anyway so there's likely to be no real-world impact. Also: - Adds typescript dep to tests that test typescript, otherwise tests fail with 'cannot determine executable to run' - unless you have tsc installed globally I guess? - Fixes a typo in a comment - Simplifies .gitignore Fixes #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserify/browser-resolve#101 (comment)
I've changed the
browserfield to point to thecjsversion of this module in line with the above comment because this module is currently broken when used with browserify.I've also added the util module as a dep since it's used in the code. It would be ignored in most environments so the only cost is a slightly larger bundle but it's likely to be included in any non-trivial bundle somewhere anyway so there's likely to be no real-world impact.
Also:
Fixes #19