Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add threshold_ms for conditional timing metrics #27

Merged
merged 1 commit into from
Dec 11, 2020
Merged

[feat] add threshold_ms for conditional timing metrics #27

merged 1 commit into from
Dec 11, 2020

Conversation

aviramha
Copy link
Contributor

@aviramha aviramha commented Dec 9, 2020

No description provided.

@aviramha
Copy link
Contributor Author

@Gr1N Awaiting review :)

Gr1N
Gr1N reviewed Dec 10, 2020
View reviewed changes
aiodogstatsd/client.py Outdated Show resolved Hide resolved
@Gr1N
Copy link
Owner

Gr1N commented Dec 10, 2020

@aviramha hi! Thanks for the contribution, please check my review.

@aviramha aviramha force-pushed the conditional_timeit branch 2 times, most recently from 2ba72c1 to 6eb13b2 Compare December 10, 2020 14:45
@aviramha
Copy link
Contributor Author

@Gr1N Thanks for the CR. I fixed it, I think that bool check is enough because if it's 0 then checking greater/less than is useless..

@aviramha aviramha requested a review from Gr1N December 10, 2020 14:46
@Gr1N Gr1N merged commit f87ceb3 into Gr1N:master Dec 11, 2020
@Gr1N Gr1N mentioned this pull request Dec 11, 2020
Closed
@Gr1N
Copy link
Owner

Gr1N commented Dec 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gr1N Gr1N Awaiting requested review from Gr1N

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviramha @Gr1N