fix block in close() #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gr1N
reviewed
Feb 14, 2020
|
Hi and thank you for your contribution. Please fix a few moments:
|
Gr1N
reviewed
Feb 14, 2020
In case that close() is called while doing read operation, the close() call is blocked and whole application is stucked. Shut-down of socket will resolve this issue and releases thread blocked at readline(). Regression test for graceful shutdown also included.
|
LGTM! Thank you for your contribution. I will release a new version of package this weekend. |
|
New version of package just published:
@richard78917 enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that close() is called while doing
read operation, the close() call is blocked and whole application
is stucked.