Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR feedback #7

Merged
merged 2 commits into from
Jun 29, 2020
Merged

PR feedback #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb4373
Fix IL linker trimming value
GrabYourPitchforks Jun 29, 2020
9dfd125
Suppress failing wasm tests
GrabYourPitchforks Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<method signature="System.Boolean get_Invariant()" body="stub" value="true" feature="System.Globalization.Invariant" featurevalue="true" />
</type>
<type fullname="System.LocalAppContextSwitches">
<method signature="System.Boolean get_EnableUnsafeUTF7Encoding()" body="stub" value="true" feature="System.Text.Encoding.EnableUnsafeUTF7Encoding" featurevalue="true" />
<method signature="System.Boolean get_EnableUnsafeUTF7Encoding()" body="stub" value="false" feature="System.Text.Encoding.EnableUnsafeUTF7Encoding" featurevalue="false" />
</type>
</assembly>
</linker>
2 changes: 2 additions & 0 deletions src/libraries/System.Text.Encoding/tests/Encoding/Encoding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public static void GetEncodingsTest()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
[Theory]
[MemberData(nameof(Encoding_TestData))]
public static void VerifyCodePageAttributes(int codepage, string name, string bodyName, string headerName, bool isBrowserDisplay,
Expand All @@ -81,6 +82,7 @@ public static void VerifyCodePageAttributes(int codepage, string name, string bo
Assert.Equal(windowsCodePage, encoding.WindowsCodePage);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
[Theory]
[MemberData(nameof(Normalization_TestData))]
public static void NormalizationTest(int codepage, bool normalized, bool normalizedC, bool normalizedD, bool normalizedKC, bool normalizedKD)
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Text.Encoding/tests/Encoding/EncodingGetEncodingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public CodePageMapping(string name, int codepage)
new CodePageMapping("x-unicode-2-0-utf-8", 65001)
};

[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
[Fact]
public void TestEncodingNameAndCopdepageNumber()
{
Expand All @@ -99,6 +100,7 @@ public void TestEncodingNameAndCopdepageNumber()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
[Fact]
public void GetEncoding_EncodingName()
{
Expand All @@ -118,6 +120,7 @@ public void GetEncoding_EncodingName()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
[Fact]
public void GetEncoding_WebName()
{
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingEncode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

namespace System.Text.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
public class UTF7EncodingEncode
{
public static IEnumerable<object[]> Encode_Basic_TestData()
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Text.Encoding/tests/UTF7Encoding/UTF7EncodingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

namespace System.Text.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38433", TestPlatforms.Browser)] // wasm doesn't honor runtimeconfig.json
public class UTF7EncodingTests
{
[Fact]
Expand Down