Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue that ThemeHelper isn't enabled after reloading. #51

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mntone
Copy link
Contributor

@mntone mntone commented Sep 4, 2020

  • Fixed an issue that the object with ThemeHelper.HasThemeResources was unloaded and reloaded, but the ThemeHelper feature was still disabled.
    • Added the implementation to observe FrameworkElement.Loaded with a weak event manager.
    • In the Showcase app, you can check it by switching tabs.

  • ThemeHelper.HasThemeResources がついているオブジェクトがアンロードされた後,再度ロードされても ThemeHelper の機能が無効になっている問題の修正。
    • FrameworkElement.Loaded を weak event manager で監視する実装を追加しています。
    • Showcase アプリではタブ切り替えで確認できます。

nishy2000 added a commit to nishy2000/MetroRadiance.Fork that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant