Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max PGM number for MIDI send event Cx Program Change Range isn't 2097152 #1058

Closed
willeke1234 opened this issue Mar 1, 2022 · 0 comments · Fixed by #1071
Closed

Max PGM number for MIDI send event Cx Program Change Range isn't 2097152 #1058

willeke1234 opened this issue Mar 1, 2022 · 0 comments · Fixed by #1071
Labels
bug Something isn't working

Comments

@willeke1234
Copy link
Contributor

The max PGM number for MIDI send event Cx Program Change Range varies.
The Help says "Range is [0, 2097152]" but that should be [1, 2097152] I think.
The maximum value I can enter in the dialog is 999999.
If I enter 200000 in the dialog and export and import the settings (= preset) then I get "Out of range value at section 'Switch012entryMIDISendLowValue001, 200000". The maximum value allowed in GOrgueMidiSender::Loadis0x3fff` (16383).

The max PGM number for MIDI receive event Cx Program Change Range is also limited to 999999 in the dialog.
@oleg68 oleg68 added the bug Something isn't working label Mar 1, 2022
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Mar 4, 2022
Fixed limits for PGM numbers of the Cx Program Change Range midi event …
8076ce2 
…GrandOrgue#1058
@oleg68 oleg68 mentioned this issue Mar 4, 2022
Merged
oleg68 added a commit that referenced this issue Mar 6, 2022
@oleg68
Fixed limits for PGM numbers of the Cx Program Change Range midi event …
f564095 
…#1058 (#1071)

Co-authored-by: Oleg Samarin <osamarin@openwaygroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed limits for PGM numbers of the Cx Program Change Range midi event oleg68/GrandOrgue-official
2 participants
@oleg68 @willeke1234