Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability of loading and saving combinations to the Combination Setter panel. #1196

Closed
oleg68 opened this issue Sep 15, 2022 · 7 comments · Fixed by #1475
Closed

Add capability of loading and saving combinations to the Combination Setter panel. #1196

oleg68 opened this issue Sep 15, 2022 · 7 comments · Fixed by #1475
Labels
enhancement New feature or request
Milestone

Comments

@oleg68
Copy link
Contributor

oleg68 commented Sep 15, 2022

Now exporting and importing combinations are possible only with a menu.

It would be more convinient to do it with special controls in the Combination Setter panel. Hauprtwerk already has a similar capability.

@oleg68
Copy link
Contributor Author

oleg68 commented Apr 13, 2023

@larspalo @rousseldenis

I'm trying to add more controls to the sequencer panel.

What variant is better:
classic

or

newui?

@larspalo
Copy link
Contributor

@oleg68 The first one. Not the green icons please.

@Jean-Gabriel1982
Copy link

Why not take the opportunity to modernize the interface?

For example
image

@larspalo
Copy link
Contributor

Becacuse the icons doesn't actually say what the buttons are doing. An arrow right means what... Right? Whereas the text is immediately obvious to anyone that can read. Not to mention that the icons have a style that doesn't match the existing drawstop (buttons) at all.

@rousseldenis
Copy link
Contributor

Yes I +1 for the first option too. To be more compliant with the current toolkit library, we should not break the user experience. Maybe in a soon future, doing a revamp of the whole toolkit should be done

@larspalo
Copy link
Contributor

@rousseldenis In my opinion, if we want to modernize the built-in graphics, it should be done as new additional bitmaps (and using them inside GO by setting new defaults). But they should all be really thought through so that they will harmonize together in a coherent style.

@oleg68
Copy link
Contributor Author

oleg68 commented Apr 14, 2023

OK, let's choose the first variant. I'm finishing working on the issue now. The evaluation build is already abvailable at https://github.com/oleg68/GrandOrgue-official/actions/runs/4693356345 .

As soon I adjust the help, I'll open a PR with it.

oleg68 added a commit that referenced this issue Apr 17, 2023
…inations files on the Combination Setter panel #1196 (#1475)
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Apr 23, 2023
https://build.opensuse.org/request/show/1082289
by user expeehaa + dimstar_suse
- Update to version 3.11.0.
  Changelog: https://github.com/GrandOrgue/grandorgue/releases/tag/3.11.0-1
  - Added capability of navigating over, loading and saving the YAML combinations files on the Combination Setter panel GrandOrgue/grandorgue#1196
  - Added capability of exporting and importing combinations in yaml format files GrandOrgue/grandorgue#1195
  - Removed support of old linux distros (with libc6 versions before 2.31) GrandOrgue/grandorgue#1334
  - Fixed the translation of the desktop icon on Linux GrandOrgue/grandorgue#1429
  - Added support of labels without a background image by specifying DispImageNum=0 GrandOrgue/grandorgue#1386
  - Added c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants