Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of WindchestGroup objects is limited to 50 #1484

Closed
eturpault opened this issue Apr 20, 2023 · 1 comment · Fixed by #1487
Closed

Number of WindchestGroup objects is limited to 50 #1484

eturpault opened this issue Apr 20, 2023 · 1 comment · Fixed by #1487
Milestone

Comments

@eturpault
Copy link
Contributor

The current implementation of GrandOrgue limits the number of WindchestGroup objects at 50.
Since v2.2 OdfEdit converts to GrandOrgue ODF the volume sliders/enclosures of Hauptwerk sample sets. This can generate more than 50 WindchestGroup objects in the GO ODF with some sample sets.
Example : the Dom Bedos sample set of Sonus Paradisi for which 79 WindchestGroup objects are generated by OdfEdit : one slider to tune the volume of each stop, and each stop being divided in two windchests (left and right), plus the tracker volume slider and blower volume slider.
Could the maximum number of WindchestGroup objects be increased to 100 for example ?

@eturpault
Copy link
Contributor Author

eturpault commented May 4, 2023

With this change I get no more an error for the WindchestGroup objects number of the Dom Bedos sample set, thank you.
However now I get another error (not visible before), it is with the Enclosure objects number which exceeds the maximum value (50) as well with Dom Bedos, there are 58 enclosures built by OdfEdit (one enclosure per stop + enclosures for blower noise volume and tracker noise volume).
@oleg68 could you please also increase to 999 the maximum number of enclosures ? Do you want I open another issue for that ?
This sample set has 112 ranks, 64 switches, 5 manuals, it will not be a problem.
When I will have impleted the conditional switches convertion, the number of switches should be high with some sample sets, but it should not exceed 999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants