Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash to desktop Win10 large registration #847

Closed
mutti-wilson opened this issue Nov 14, 2021 · 13 comments · Fixed by #860
Closed

Crash to desktop Win10 large registration #847

mutti-wilson opened this issue Nov 14, 2021 · 13 comments · Fixed by #860
Labels
bug Something isn't working
Milestone

Comments

@mutti-wilson
Copy link

@oleg68 asked for a crashdump to see what's going on. Crashes after playing large registration.

I'm using the latest 3.4.2-0.2 build by @oleg68

GrandOrgue.exe.8792.zip

@oleg68
Copy link
Contributor

oleg68 commented Nov 14, 2021

@mutti-wilson Please try to use grandorgue-3.4.2-1.847.1.windows.x86_64.zip
(without installation; just unpack it to some directory and run bin\GrandOrgue.exe) and post here the new crash dump from this version.

@mutti-wilson
Copy link
Author

mutti-wilson commented Nov 15, 2021

Here are 2 crash dumps. I don't know why they have a duplicate file name since the time generated is the same but they are slightly different sized so I thought sending both would be wise.

CrashDumps.zip

@oleg68 oleg68 added the bug Something isn't working label Nov 15, 2021
@oleg68 oleg68 added this to the 3.4.3 milestone Nov 15, 2021
@mutti-wilson
Copy link
Author

So if it matters I have a little info to add as well as another crash dump. The first crash was using WDM drivers, second was ASIO and this crash was using Direct Sound. Direct sound lasted the longest before crashing. If you need any other background let me know and I'll do what I can to answer. Thanks for digging in on this.

CrashDumps.zip

@oleg68
Copy link
Contributor

oleg68 commented Nov 16, 2021

Thank you, @mutti-wilson I will discover your crash dumps.

@oleg68
Copy link
Contributor

oleg68 commented Nov 16, 2021

Asio:

   ExceptionCode: c0000005 (Access violation)
Attempt to read from address 000000000000008c

00000000`008ff0a8 00000000`004afc6b : 00000000`0fa17860 00000000`0000000e 00000000`00000000 00000000`0000000f : GrandOrgue!GetVelocityVolume+0xb
00000000`008ff0b0 00000000`0fa17860 : 00000000`0000000e 00000000`00000000 00000000`0000000f 00000000`0fa17860 : GrandOrgue!UpdateVelocity+0x1b

@oleg68
Copy link
Contributor

oleg68 commented Nov 16, 2021

DirectSound:

00000000`008ff0a8 00000000`004afc6b : 00000000`0fa17860 00000000`0000000e 00000000`00000000 00000000`0000000f : GrandOrgue!GetVelocityVolume+0xb
00000000`008ff0b0 00000000`0fa17860 : 00000000`0000000e 00000000`00000000 00000000`0000000f 00000000`0fa17860 : GrandOrgue!UpdateVelocity+0x1b
  • The same as asio.

So this problem seems relates neither the sound driver nor windows, but when the same pipe is referenced from different ranks.

Another possible reason - the metronome.

@oleg68
Copy link
Contributor

oleg68 commented Nov 16, 2021

@mutti-wilson Could you try the new version?

When it crashes then post the crash dump here.

What organ are you playing? Is the metronome switched on when GO crashes?

oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 16, 2021
@mutti-wilson
Copy link
Author

@oleg68 I am using Friesach. I've never used the metronome. I remember poking around in the ODF for some reason but I don't think I made any changes. I will check and see if the metronome got switched on somehow. I'll dig around and try out the new version tonight as well. Does the debug log point to any pipe specifically?

@mutti-wilson
Copy link
Author

@oleg68 I used the new build and played for almost 2 hours with all stops and couplers pulled and experienced no crashes. I changed back to ASIO because I feel like the latency is superior and knowing that it crashed often using ASIO I thought that would be a good test. Seems like it's fixed. I have an untouched ODF of Friesach that I did not try as it would be too many variables and harder to pin down what actually fixed it.

@oleg68
Copy link
Contributor

oleg68 commented Nov 17, 2021

@mutti-wilson Thank you for your test. It is not a final fix yet, but I'll work on it for the official version.

oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 17, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 17, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 17, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 17, 2021
@oleg68
Copy link
Contributor

oleg68 commented Nov 17, 2021

@mutti-wilson please try the official intermediate build with fixing this issue

@mutti-wilson
Copy link
Author

@oleg68 I will install this when I get home this evening.

@mutti-wilson
Copy link
Author

@oleg68 This build worked great. No crashes at all. Thanks so much. I'm back in business and hopefully others will benefit from this fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants