Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased maximum allowed (panel) size to 32000. #1843

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

larspalo
Copy link
Contributor

Resolves #1840

@oleg68
Copy link
Contributor

oleg68 commented Mar 16, 2024

@larspalo It looks all right, but seems gui/GOGUISizeKeeper.cpp, line 16 should be adjusted as well.

@larspalo
Copy link
Contributor Author

@oleg68 Right, I never tried to save any config. Also the tested panel/image size of 5760 would not have triggered an issue with that. I'll change that to 32000 too.

@oleg68
Copy link
Contributor

oleg68 commented Mar 17, 2024

@larspalo please resolve the conflict.

src/grandorgue/gui/GOGUISizeKeeper.cpp has been moved to src/grandorgue/size/GOSizeKeeper.cpp

@oleg68 oleg68 mentioned this pull request Mar 20, 2024
4 tasks
@larspalo
Copy link
Contributor Author

@rousseldenis Could you please approve of this PR, it's just changing a simple allowed panel width number... Not very much to think about!

@larspalo larspalo merged commit 7343be9 into GrandOrgue:master Mar 22, 2024
1 check passed
@larspalo larspalo deleted the AllowLargerSizes branch March 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

size limit for images in GO
3 participants