Changed displaying of the right part of paths https://github.com/GrandOrgue/grandorgue/issues/1663 #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleg68 It seems like the church name will overflow into the package name column if it's empty:
If the package name column has content, the church name will not overflow:
I think it would be better if the church name didn't overflow at all. Also you can see the package paths again being right aligned - which is not so nice, but I guess that it would be fixed with the previous PR that has not yet been merged with this one, right? |
oleg68
force-pushed
the
feature/organ-selection-paths
branch
from
86591df
to
212a952
Compare
|
@larspalo fixed both issues |
|
@larspalo @rousseldenis could you look at this PR? |
larspalo
approved these changes
Mar 27, 2024
rousseldenis
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1663
This is the last PR related to #1663.
This PR