Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hang when using a cached organ #1941

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fixed hang when using a cached organ #1941

merged 1 commit into from
Jul 13, 2024

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Jul 6, 2024

This PR fixes a bug introduced with #1919

When an organ had been loaded from a cache playing it could hang.

The root cause was that GOSoundAudioSection::EndSegment::end_pos stopped saving to the cache.

This PR

  • Added protection to GOSoundStream::ReadBlock against hang even the samples are not valid
  • Extracted the static fields of GOSoundAudioSection::EndSegment to the base GOSoundAudioSection::EndSegmentDescription
  • Reading/Writing GOSoundAudioSection::EndSegmentDescription to the cache as whole object instead of operating of separated fields, that fixes the root cause

@oleg68 oleg68 requested review from larspalo and rousseldenis July 6, 2024 19:49
@oleg68 oleg68 merged commit faa554b into GrandOrgue:master Jul 13, 2024
1 check passed
@oleg68 oleg68 deleted the bugfix/cache-hang branch July 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@larspalo larspalo larspalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg68 @larspalo @rousseldenis