Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed GOCombinationElement::SetCombination to SetCombinationState #2011

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Renamed GOCombinationElement::SetCombination to SetCombinationState #2011

merged 5 commits into from
Sep 24, 2024

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Sep 21, 2024 •
edited
Loading

This PR

  • Renames GOCombinationElement::SetCombination to SetCombinationState
  • Deletes the unused member GODrawstop::m_CombinationState
  • Renames GOButtonControl::Set to SetButtonState
  • Renames GODrawStop::ChangeState to OnDrawsStopChanged
  • Renames GODrawStop::SetState to SetDrawstopChanged and made it private

It is just renaming. No GO behavior should be changed.

@oleg68 oleg68 merged commit c3108c4 into GrandOrgue:master Sep 24, 2024
1 check passed
@oleg68 oleg68 deleted the refactor/set-combination branch September 24, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larspalo larspalo larspalo approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg68 @larspalo @rousseldenis