Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer.json validation #35

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Fix composer.json validation #35

merged 1 commit into from
Feb 22, 2016

Conversation

j0k3r
Copy link
Contributor

@j0k3r j0k3r commented Feb 8, 2016

See https://getcomposer.org/doc/04-schema.md for details on the schema

  • The version field is present, it is recommended to leave it out if the package is published on Packagist.
  • require.phpzip/phpzip : unbound version constraints (>=2.0.7) should be avoided
  • require.grandt/phpresizegif : unbound version constraints (>=1.0.4) should be avoided
  • require.grandt/relativepath : unbound version constraints (>=1.0.1) should be avoided

Also grandt/phpresizegif version 1.0.4 doesn't exist.

@Grandt
Copy link
Owner

Grandt commented Feb 21, 2016

I can see the problems with the unbound versions, but why remove the package version (4.0.6) ?

@j0k3r
Copy link
Contributor Author

j0k3r commented Feb 22, 2016

This is explained here.

Grandt added a commit that referenced this pull request Feb 22, 2016
@Grandt Grandt merged commit 69431b9 into Grandt:master Feb 22, 2016
@Grandt
Copy link
Owner

Grandt commented Feb 22, 2016

Got it. Thanks. Merged.

@j0k3r j0k3r deleted the composer-validation branch February 22, 2016 08:14
@j0k3r
Copy link
Contributor Author

j0k3r commented Feb 22, 2016

✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants