feat:break change v0.28.0 transaction response #97
Conversation
Signed-off-by: grapebaba <281165273@qq.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| deserializer.decrease_container_depth(); | ||
| return builder.build(); | ||
| } | ||
|
|
||
| public static ObjectFormatOptions bcsDeserialize(byte[] input) throws com.novi.serde.DeserializationError { | ||
| public static MoveLocationOpt bcsDeserialize(byte[] input) throws com.novi.serde.DeserializationError { | ||
| if (input == null) { | ||
| throw new com.novi.serde.DeserializationError("Cannot deserialize null array"); | ||
| } | ||
| com.novi.serde.Deserializer deserializer = new com.novi.bcs.BcsDeserializer(input); |
There was a problem hiding this comment.
UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.
| com.novi.serde.Deserializer deserializer = new com.novi.bcs.BcsDeserializer(input); | |
| public static MoveLocationOpt deserialize(Deserializer deserializer) throws com.novi.serde.DeserializationError { |
❗❗ 710 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/io/sui/bcsgen/ExecutionFailureStatus.java | 1169 |
| src/main/java/io/sui/bcsgen/MoveLocation.java | 14 |
| src/main/java/io/sui/bcsgen/TransactionExpiration.java | 13 |
| src/main/java/io/sui/bcsgen/CommandArgumentError.java | 247 |
| src/main/java/io/sui/bcsgen/CommandArgumentError.java | 198 |
| src/main/java/io/sui/bcsgen/TraitHelpers.java | 382 |
| src/main/java/io/sui/bcsgen/Argument.java | 90 |
| src/main/java/io/sui/bcsgen/TraitHelpers.java | 325 |
| src/main/java/io/sui/bcsgen/CommandArgumentError.java | 205 |
| src/main/java/io/sui/bcsgen/ConsensusCommitPrologue.java | 6 |
Showing 10 of 710 findings. Visit the Lift Web Console to see all.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * | ||
| * @param splitCoin the split coin | ||
| */ | ||
| public void setSplitCoin(Command.SplitCoin splitCoin) { |
There was a problem hiding this comment.
InconsistentCapitalization: Found the field 'SplitCoin' with the same name as the parameter 'splitCoin' but with different capitalization.
| public void setSplitCoin(Command.SplitCoin splitCoin) { | |
| public void setSplitCoin(Command.SplitCoin SplitCoin) { |
❗❗ 11 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/io/sui/models/transactions/Argument.java | 56 |
| src/main/java/io/sui/models/transactions/TransactionKind.java | 98 |
| src/main/java/io/sui/models/transactions/Argument.java | 150 |
| src/main/java/io/sui/models/transactions/Command.java | 51 |
| src/main/java/io/sui/models/transactions/TransactionKind.java | 197 |
| src/main/java/io/sui/models/transactions/Command.java | 239 |
| src/main/java/io/sui/models/transactions/Argument.java | 103 |
| src/main/java/io/sui/models/transactions/Command.java | 192 |
| src/main/java/io/sui/models/transactions/Command.java | 98 |
| src/main/java/io/sui/models/transactions/TransactionKind.java | 146 |
Showing 10 of 11 findings. Visit the Lift Web Console to see all.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| @SuppressWarnings("checkstyle:MemberName") | ||
| private TransferSui TransferSui; | ||
| private ProgrammableTransaction ProgrammableTransaction; |
There was a problem hiding this comment.
VariableNameSameAsType: Variable named ProgrammableTransaction has the type ProgrammableTransaction. Calling methods using "ProgrammableTransaction.something" are difficult to distinguish between static and instance methods.
❗❗ 8 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/io/sui/models/transactions/Command.java | 176 |
| src/main/java/io/sui/models/transactions/TransactionKind.java | 82 |
| src/main/java/io/sui/models/transactions/Command.java | 270 |
| src/main/java/io/sui/models/transactions/Command.java | 129 |
| src/main/java/io/sui/models/transactions/TransactionKind.java | 129 |
| src/main/java/io/sui/models/transactions/Argument.java | 134 |
| src/main/java/io/sui/models/transactions/Command.java | 82 |
| src/main/java/io/sui/models/transactions/Command.java | 35 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
@sonatype-lift ignoreall
There was a problem hiding this comment.
The ignoreall command is active on this PR, all the existing Lift issues are ignored.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/GrapeBaBa/sui4j/97.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/GrapeBaBa/sui4j/97.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
No description provided.