Render below status bar in portrait orientation on devices with a display cutout #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Are you able to provide screenshots of what the app looks like now, and what it looks like with this PR? |
|
Yeah sure, here you go: Before: After: |
thestinger
force-pushed
the
main
branch
2 times, most recently
from
2d660f2
to
c9eb422
Compare
soupslurpr
force-pushed
the
render-below-status-bar-on-devices-with-display-cutout
branch
from
8e6081e
to
426a81c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On devices with a display cutout, instead of hiding the status bar which shows a black bar, this makes it render below the bar by not hiding it when in portrait. Also uses the newer way to get the WindowInsetsController for SDKs supporting it.