Update TalkBack to v14.1

[PatrykMis]

Like @thestinger have asked in #50 (comment).

Tested and updated everything. In addition, two small upstream issues have been fixed.

[PatrykMis]

Rebased onto recently pushed v14.1 release.

[thestinger]

Thanks, we'll try to get to this soon.

[PatrykMis]

I have to fix few upstream crashes though, especially in TalkBack's preferences.

[PatrykMis]

Crashes fixed, one thing which seams to not work at all is haptic feedback, I really don't have an idea how to debug and restore it.

[thestinger]

Missing a permission or something?

[thestinger]

I don't understand why they do such a bad job with this.

[PatrykMis]

Ok, haptic feedback is not working properly on some devices even on version from Play Store, so I think it's not worth fixing.

Icon detection is not working on FOSS version because it needs proprietary module, so considering to remove this option from preferences, what do you think?

Also, to remove Network permission? In fact, it's not being used for anything other than analytics and performance metrics, OCR is being performed by MLKit offline.

[thestinger]

Ok, haptic feedback is not working properly on some devices even on version from Play Store, so I think it's not worth fixing.

That seems unfortunate since they'll probably fix it there.

[thestinger]

Maybe it's just broken on older Android versions? Where is it broken?

[thestinger]

Also, to remove Network permission? In fact, it's not being used for anything other than analytics and performance metrics, OCR is being performed by MLKit offline.

Seems fine to remove it.

[PatrykMis]

That seems unfortunate since they'll probably fix it there.

If they fix it, we can try with decompiling Play variant, as they are not obfuscating source code at all; also no specific Proguard optimizations there.

[PatrykMis]

Maybe it's just broken on older Android versions? Where is it broken?

Rather on A14, I will test it on other devices than Pixel 8 tomorrow.

[thestinger]

@PatrykMis Do you think this should be merged? It's looking like there was a lot broken.

[PatrykMis]

In general, it is ready to merge: lots of new features have been added, including text editing in braille keyboard, etc. It has been tested extensively by me for half a month. Additionally, the haptic feedback is working well when touch feedback is enabled in system settings, too.

However, there are still some minor tweaks that can be made, such as removing the option for the stub function to download dynamic features for icon detection, as this will not work in the open-source version.

[PatrykMis]

@thestinger Now everything is working as expected, ready to merge (rebase).

[PatrykMis]

Rebased with AGP updated to v8.3.2 and cleaner GIT commit history, no special changes.

[thestinger]

@PatrykMis Going to try to include it in the next release.

[thestinger]

@PatrykMis It would be nice to switch it to Java 17 since it's the last thing still using Java 11. Would need to be tested with that before shipping it that way though.

[thestinger]

@PatrykMis Can you test the build we have at https://github.com/GrapheneOS/platform_external_talkback? Note: it's not signed, since we currently let it get signed with the OS releasekey but we could stop doing that to start updating it out-of-band at some point. It gets updated so infrequently that we haven't bothered though.

[matchboxbananasynergy]

I think being able to update it out-of-band can be very useful in the off chance some regression is introduced. It's best to not require an OS update for that.