Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transforming layers #244

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Allow transforming layers #244

merged 2 commits into from
Jul 11, 2021

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Jul 11, 2021

Closes #243 and unblocks #201 and #143.

I accidentally used the wrong function to get the layer. I can't find one that gets the root with an empty path and the layer / folder if that is where the path is pointing (unless I'm missing something @TrueDoctor) so I made a new one.


This change is Reviewable

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0fe5f1
Status: ✅  Deploy successful!
Preview URL: https://d5795cdd.graphite-master.pages.dev

View logs

Copy link
Member

@TrueDoctor TrueDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not verified the transformation change, but this looks good to merge

@0HyperCube 0HyperCube merged commit 721f418 into master Jul 11, 2021
@0HyperCube 0HyperCube deleted the transforming-layers branch July 11, 2021 09:24
henryksloan added a commit to henryksloan/Graphite that referenced this pull request Jul 13, 2021
* Allow transforming layers

* Add document_layer function to return non mut
Keavon pushed a commit that referenced this pull request Jun 16, 2022
* Allow transforming layers

* Add document_layer function to return non mut
Keavon pushed a commit that referenced this pull request Jul 30, 2023
* Allow transforming layers

* Add document_layer function to return non mut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow layers, not only folders, to have transforms
2 participants