Follow the official server's protocol for clearing energy on burst. #1261

GanyusLeftHorn · 2022-06-14T17:30:24Z

Description

This PR adapts the protocol used to clear energy to what the official server seems to be doing. Changes:

Send EntitiyFightPropUpdateNotify instead of AvatarFightPropUpdateNotify on energy clear.
Send EntityFightPropChangeReasonNotify with energy change reason CHANGE_ENERGY_REASON_SKILL_START when clearing energy due to burst cast.

My code follows the style guidelines of this project
My pull request is unique and no other pull requests have been opened for these changes
I have read the Contributing note and Code of conduct
I am responsible for any copyright issues with my code if it occurs in the future.

ImmuState added 2 commits June 14, 2022 10:08

Adapt protocol for clearing energy.

f07e983

Only send full clear notification on burst cast.

ac56c35

GanyusLeftHorn mentioned this pull request Jun 14, 2022

[Bug] Energy will be cleared but elemental burst will not be released #1248

Closed

ghost approved these changes Jun 15, 2022

View reviewed changes

ghost merged commit ed290b6 into Grasscutters:development Jun 15, 2022

GanyusLeftHorn deleted the burst_energy branch June 15, 2022 20:13

This pull request was closed.