Update Netty to the latest version #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick smoke-test of the application was successful. |
mpfz0r
reviewed
Mar 3, 2021
pom.xml
Outdated
| @@ -135,7 +135,7 @@ | |||
| <mongodb-driver.version>3.12.1</mongodb-driver.version> | |||
| <mongojack.version>2.10.1</mongojack.version> | |||
| <natty.version>0.13</natty.version> | |||
| <netty.version>4.1.52.Final</netty.version> | |||
| <netty.version>4.1.59.Final</netty.version> | |||
| <netty-tcnative-boringssl-static.version>2.0.34.Final</netty-tcnative-boringssl-static.version> | |||
There was a problem hiding this comment.
Would you mind als updating netty-tcnative to 2.0.36?
We've had problems with that in the past, so it's a good practice to update them together
There was a problem hiding this comment.
For reference: https://github.com/netty/netty-tcnative/releases
There was a problem hiding this comment.
Thanks for the suggestion. Done.
bernd
requested changes
Mar 9, 2021
mpfz0r
approved these changes
Mar 9, 2021
|
@bernd can you approve or remove your change request? |
bernd
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Netty dependency to the latest version.
This was recently done in Graylog2/gelfclient#52, so the same update is being done in the graylog2-server core while we're looking at this.