-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.2 #597
Merged
Merged
Release v0.3.2 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Currently the mergeObject function has a couple of problems. E.g. it overrides an input if its value is false and the default is true. It does not deep merge objects. Added a test suite that the current function would not pass. And fixed it. Signed-off-by: alexzurbonsen <alexander.zur.bonsen@tngtech.com>
…nit-tests Parameterize unit tests
optimize merge defaults strategy
- there is another manifest demostrating the plugin
Add unit test for args.ts
chore(package): release v0.3.2 ✨
narekhovhannisyan
requested review from
manushak,
jmcook1186 and
MariamKhalatova
April 9, 2024 20:22
jmcook1186
approved these changes
Apr 9, 2024
MariamKhalatova
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request